search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Support component param from angular bootstrap dialog #190

Closed roychoo closed 6 years ago

roychoo commented 6 years ago

Hi,

I realised that dialog.create didn't support component param.

thus created PR #189 .

niemyjski commented 6 years ago

Thanks for the pr

roychoo commented 6 years ago

np @niemyjski may i know when would you do a release so that it contains this feature?

niemyjski commented 6 years ago

It would be nice if some of these other pr's went out with a release, would you mind helping review them.

Thanks -Blake Niemyjski

On Thu, Jan 11, 2018 at 9:11 PM, Roy Choo notifications@github.com wrote:

np @niemyjski https://github.com/niemyjski may i know when would you do a release so that it contains this feature?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/m-e-conroy/angular-dialog-service/issues/190#issuecomment-357131342, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-So3gX289iTGoRoz9QAuns7rltyPNFks5tJs1ngaJpZM4RaXmR .

roychoo commented 6 years ago

Sure thanks for the reply. I will take a look later.