search

m-fleury / isabelle-emacs

Clone of isabelle, with LSP extensions in seperate branches
Other
25 stars 5 forks source link

Update README.org #43

Closed gh-salt closed 3 years ago

gh-salt commented 3 years ago

In the install instructions, Isabelle2019 is used...

tani commented 3 years ago

You can use Isabelle2020 and 2021. In the fact, I am using them.

gh-salt commented 3 years ago

The text in "Install (as a developer) > spacemacs > Create the private layer lisp-mode" (that should be lsp-mode) also needs some work since it seems the lsp-mode layer has disappeared from the repo. @m-fleury are you using the official spacemacs lsp layer instead now?

PS: Hello @tani , thanks for your answer. :) In fact I am switching to Isabelle2021 (from 2020) and checking what needs to be improved in the Readme along the way. I opened this issue as a kind of todo list. Don't hesitate to report here if you stumble upon anything that needs to be updated in the readme.

m-fleury commented 3 years ago

Are you using master instead of develop for spacemacs? (Good point: this should be documented).

But yes, I rely on the official lsp layer.

The main reason for using develop instead of master is that spacemacs has not seen a real release in a very long time (at some point, there was a release but it was never tagged as such on their git). Additionally, various bugs have been fixed in the development version but not in master.

There were some discussions to make spacemacs a rolling release (aka using the develop version, which various people already advise to do), but that discussion never reached a conclusion.

tani commented 3 years ago

@gh-salt Ah, thank you for the explanation. I'll write it if I found some update.

I am doom-emacs user. I'd like to contribute my configuration to this readme. However, I feel better contributing my update to the official doom repository. Which do you prefer?

tani commented 3 years ago

If @m-fleury doesn't mind it, I suggest changing the repository name. isabelle-release looks like the just mirror of the official repository. I missed this repository when I searched such projects by Google.

m-fleury commented 3 years ago

I also have a doom config for Isabelle actually (but I stopped using it).

As far as I know, there are 3 people using Isabelle/emacs [1] so I am not certain that contributing your configuration to the official doom makes much sense. But I don't have an opinion on that.

[1] well until your message I thought that number was 2 so my numbers might be wildly off.

gh-salt commented 3 years ago

I am using develop for spacemacs.

For lsp, all that there is to do is to add lsp in the list of layers along with isabelle, correct?

m-fleury commented 3 years ago

Ah, my c-c++ config is probably already importing lsp transitively. Yes, adding lsp should be sufficient.

gh-salt commented 3 years ago

If @m-fleury doesn't mind it, I suggest changing the repository name. isabelle-release looks like the just mirror of the official repository. I missed this repository when I searched such projects by Google.

This topic should be moved to another issue since this is not related to the readme.

gh-salt commented 3 years ago

Ah, my c-c++ config is probably already importing lsp transitively. Yes, adding lsp should be sufficient.

I'll updatet the readme then.

gh-salt commented 3 years ago

In "Post-Installation > Adding the AFP" the path contains "Isabelle2021". Shouldn't it be "Isabelle2021-vsce"?

m-fleury commented 3 years ago

Yes.

At some point, I could also change Isabelle such that it reports the version "Isabelle2021" instead of "Isabelle2021-vsce" (aka uses the same configuration files as the release).

gh-salt commented 3 years ago

I would prefer that these stay separated, but we can discuss about it at our next meeting.