search

m-h-c-t / mh-helper-extension

A Chrome / Firefox browser extension that helps collect data for HitGrab's MouseHunt game
https://www.mhct.win
MIT License
14 stars 15 forks source link

Stampede Stage Requires Charm Check #171

Open AardWolf opened 2 years ago

AardWolf commented 2 years ago

https://github.com/m-h-c-t/mh-helper-extension/blob/45565c02c70f5591a2cc4cad7635fb1d5b38fe18/src/scripts/main.js#L1492

Currently the only change in stage that can happen is if the Grubling Chow Charm is also armed. So we'll need to add that as a check.

AardWolf commented 2 years ago

Added DB Cleanup flag because we can go back and update the stage for hunts to better match the reality - "No Stampede" unless it is both a Stampede AND has the correct charm armed.

AardWolf commented 2 years ago

Bonus points if we want to add the Grubling Bonanza charm which increases AR of a grubling.

tehhowch commented 2 years ago

I believe the check is correct as-is. If we only set the "Stampede" stage when there is both a stampede and the chow charm armed, then we cannot deduce population differences between "grublings are stampeding" and "grublings are not stampeding"

In other words, I feel it is reasonable that there may be 3 distinct populations:

  1. No Stampede
  2. Stampede
  3. Stampede w/Chow Charm armed
AardWolf commented 2 years ago

I think we have a couple ways we can bring this forward. Three stages as suggested there is one of them. Another is two stages of Grublings (third stage)/No Grublings (stages one and two) but with stampede status as a hunt_detail.

The first allows for the most people to break down the ARs and DRs into the three stages, of which two might be identical - but this isn't really a problem. The second allows the two stages to be investigated in case there are differences but would require SQL.

I vote for the three stage method.

logicalup commented 2 years ago

sounds good:

  1. no stampede
  2. stampede without chow
  3. stampede with chow