Including links and images

m-haisham / novelsave

This is a tool to download and convert novels from popular sites to e-books.

Apache License 2.0

36 stars 7 forks source link

Including links and images #30

Closed ghost closed 3 years ago

ghost commented 3 years ago

Hi! 🤗 Is there a way for the links included in the websites to be also active when the epubs are made? The links don't work in the epubs even though they work on the websites. 🥺 Thank you so much in advance! ❤❤

m-haisham commented 3 years ago

If you could point me towards a specific, it would make testing easier

ghost commented 3 years ago

At the bottom of this https://chrysanthemumgarden.com/novel-tl/pubg/pubg-26/ chapter

from the site

the epub i made

m-haisham commented 3 years ago

link element is supported in epub. during the cleaning process of the chapter href (actual link, ex: <a href="https://" ></a>) of the element is being removed.

Fixing the link problem should be as simple as fixing the cleanup process.

However, i'm afraid that the <img> situation is a bit more complex.

epub's are offline documents and shoudnt request data online, this means that the images need to be downloaded and packed into the epub. While this sounds simple, the problem arises from how i dont have a system in place for this.

I do plan on writing such a system, however it might take sometime.

m-haisham commented 3 years ago

I tested using application ReadEra, It doesn't seem to show links. So I read about it online and it seems that different reading applications handle links differently.

ghost commented 3 years ago

~~Yes, I used another epub reader too and it only shows the highlighted link but it is still not working..

this is from Lithium epub reader~~

Edit: Im so sorry, i misunderstood your reply 😭 This image is from the old version. I'll try the new updated one and inform you if it works on my side. So sorry for not understanding well to your reply. 😢😅

ghost commented 3 years ago

About the system you mentioned above, that would be great 🤧 I can wait, take your time! 😍😍

ghost commented 3 years ago

Hi! The links worked on my two epub reader now. 🥳😍😍Thank you so much! 😭😭❤❤❤❤

m-haisham commented 3 years ago

Images will finally be added in #35

1ohr commented 3 years ago

hi! 🤗 thank you so much for all the efforts you make to make this possible 😭😭😭 i really really appreciate this! 🤧🤧🤧 thank you ❤❤❤

by the way, i am the person who created that issue before 😁 i just deleted that account of mine 😅 thank you again 😭😭😘😘😘