m-i-n-a-r / birday

🎉 A beautiful Kotlin app to remember birthdays and events without having to open Facebook, set alarms or rely on Google Calendar
Other
898 stars 79 forks source link

Notification Icon #316

Open akp37 opened 5 months ago

akp37 commented 5 months ago

The icon that is in the notification area becomes... erratic? when the background changes from light to dark/dark to light.

I'll try to attach a video to show what I am trying to communicate.

https://github.com/m-i-n-a-r/birday/assets/98131167/fc0f8eac-6a63-4c9e-89b7-2d215017c339

Tighbu commented 5 months ago

I see the same issue on my device, with just a simple colour scheme of black notification icons on a light background (or vice-versa when the dark theme is active)

MartinX3 commented 5 months ago

I upgraded LineageOS from A13 to A14 and now this icon is always flickering because it always moves its wings without any break.

m-i-n-a-r commented 4 months ago

I'll look into it, but it doesn't happen on my test devices (Android 13 and 14). My guess is that it's a problem out of my control, related with the animated icons. I'll let you know!

MartinX3 commented 4 months ago

Maybe playing the the 3 animation settings in the developer settings or using LineageOS and the OS color theming features (ambient color and theme color and dark/light theme) will somehow trigger it for you.

A workaround is to to put the animation setting to 5 or 10. The window and transition animations must be at least 0.5*. Setting them to off brings the flickering back.

Of course with 5* animation setting I feel like using the matrix bullet time.

Also if a modal settings dialog opens the notification icons change their colors from black to white because this dialog turns the background black. And this color changing is the same as the flickering does.

Also it would stop if the bird won't be animated. But even putting the global animation settings to off won't stop the bird moving.

If I play around with the display gap settings in the developer settings it forces a refresh of the notification bar. Then the flickering stops. But using a modal dialog inverting the notification bar colors will bring the issue back.

Also using the black theme with the white bird the flickering happens in a low frequency. Using the white theme with the black bird results in a high frequency flickering. I used the app settings to force a theme instead of the system default.

Tighbu commented 4 months ago

Could we at least have an option to turn off icon animation?

m-i-n-a-r commented 4 months ago

The option to disable animated content is in the new beta, just released. If you installed the app via Play Store, try it and let me know if the bug is fixed! If not, I'll reopen the issue.

tretkowski commented 3 months ago

The option to disable animated content is in the new beta, just released.

Is it part of 4.4.3? I couldn't find an option to disable animated content in the settings after upgrading to 4.4.3 from F-Droid...

MartinX3 commented 3 months ago

@tretkowski I have it in the experimental settings. But I installed 4.4.3 from the play store.

tretkowski commented 3 months ago

I have it in the experimental settings. But I installed 4.4.3 from the play store.

There's a new option to disable endless animations in the experimental settings, but that does not completely disable animations for me.

akp37 commented 3 months ago

I have it in the experimental settings. But I installed 4.4.3 from the play store.

There's a new option to disable endless animations in the experimental settings, but that does not completely disable animations for me.

The same thing is happening here. The animation is not fully disabled. The option reads 'the animations will run a single time'. Maybe leaving the icon static/completely disabling animations, could be a solution.

m-i-n-a-r commented 3 months ago

The notification icon is completely static when the option is enabled, while the other animations run a single time, as I wrote in the option description. I worked hours on them, I don't want to completely eliminate them :)

akp37 commented 3 months ago

I absolutely understand why you wouldn't want to disable all the animations after all that work.
However, is there no way to specifically disable the animation for the notification icon completely, and leaving the rest of the app animations as is, such as the confetti and other things? Because the notification icon still does the "blinking" as shown in my original post video, the difference now is that it stays dark for a couple seconds longer then switches to light for a couple seconds longer.

m-i-n-a-r commented 3 months ago

I joined the animations in a single setting to avoid making the app too complicated. But at this point, I have to change the option to have more combinations. My proposal is to maintain this choice in a single entry, making it a single selection dialog (like the theme color for example), with the following alternatives:

That's the most specific choice possible. Also, I'll reopen the issue since it seems more important than I thought

akp37 commented 3 months ago

Considering the main culprit is specifically the notification icon animation, the options you're proposing that specifies the notification icon staying static... Speaking for myself, I believe those options should work.