search

m-i-n-a-r / birday

🎉 A beautiful Kotlin app to remember birthdays and events without having to open Facebook, set alarms or rely on Google Calendar
Other
849 stars 77 forks source link

Keep yesterday's birthdays visible #318

Closed herrbrixter closed 1 month ago

herrbrixter commented 3 months ago

Birthdays that are missed are automatically placed on the bottom of the list and hidden. If the birthday was just yesterday, you can still greet your friend a belated happy birthday. Now, you can't do that because these birthdays are way below the list.

How about keeping yesterday's birthdays still on top of the list? Make this optional.

m-i-n-a-r commented 2 months ago

Well, that's not a bad idea, but I'm not sure how to implement it properly in the UI. I'll see what I can do 😄

m-i-n-a-r commented 1 month ago

Ok, Here's my proposal: in the quick apps bottom sheet, I'll add a little card containing the list of events occured in the last n days, with n = 3 probably. This isn't invasive (since the main list can now also be ordered alphabetically), it's quick and just works for your use case. Also, it requires less new strings (and I'm always trying to don't introduce new strings, since they have to be translated in 30+ languages) Do you agree?

herrbrixter commented 1 month ago

That sounds good. Thanks!

m-i-n-a-r commented 1 month ago

cb3726947ca17a831df846473619e741f7f417a9 done! Now, when an event was in the last 10 days (but this number might change) you will see it in a carousel in the quick apps bottom sheet 😄 I'll release this feature in the next update, in a few weeks hopefully. You can see a preview on my Telegram channel 👍

herrbrixter commented 1 month ago

Will there be a setting to enable this feature? I guess this is off by default.

m-i-n-a-r commented 1 month ago

Nope, it's always enabled, since it's not invasive at all. Of course, this section is not displayed when there aren't events in the past 10 days.