m-j-w / CpuId.jl

Ask the CPU for cache sizes, SIMD feature support, a running hypervisor, and more.
Other
54 stars 10 forks source link

Warnings in Julia v0.7 #29

Closed juliohm closed 6 years ago

juliohm commented 6 years ago

I am on the master branch:

julia> using CpuId
[ Info: Precompiling CpuId [2400aa70-7bc4-11e8-0d0f-6103d1925e2b]
┌ Warning: Deprecated syntax `call to `&` inside call to bitshift operator` at /home/juliohm/.julia/dev/CpuId/src/CpuId.jl:108.
│ Use `parenthesized call to `&`` instead.
└ @ ~/.julia/dev/CpuId/src/CpuId.jl:108
┌ Warning: Deprecated syntax `call to `&` inside call to bitshift operator` at /home/juliohm/.julia/dev/CpuId/src/CpuId.jl:109.
│ Use `parenthesized call to `&`` instead.
└ @ ~/.julia/dev/CpuId/src/CpuId.jl:109
┌ Warning: Deprecated syntax `call to `&` inside call to bitshift operator` at /home/juliohm/.julia/dev/CpuId/src/CpuId.jl:110.
│ Use `parenthesized call to `&`` instead.
└ @ ~/.julia/dev/CpuId/src/CpuId.jl:110
┌ Warning: Deprecated syntax `call to `&` inside call to bitshift operator` at /home/juliohm/.julia/dev/CpuId/src/CpuId.jl:111.
│ Use `parenthesized call to `&`` instead.
└ @ ~/.julia/dev/CpuId/src/CpuId.jl:111
┌ Warning: Deprecated syntax `call to `&` inside call to bitshift operator` at /home/juliohm/.julia/dev/CpuId/src/CpuId.jl:113.
│ Use `parenthesized call to `&`` instead.
└ @ ~/.julia/dev/CpuId/src/CpuId.jl:113

Could you please take a look?

juliohm commented 6 years ago

Plus these warnings when loading the package from another package:

[ Info: Recompiling stale cache file /home/juliohm/.julia/compiled/v0.7/ImageQuilting/O51kj.ji for ImageQuilting [e8712464-036d-575c-85ac-952ae31322ab]
WARNING: eval from module CpuId to ImageQuilting:    
Expr(:call, :cpucycle) = Expr(:block, #= Symbol("/home/juliohm/.julia/packages/CpuId/LfVX/src/CpuId.jl"):925 =#, Expr(:call, :rdtsc))
  ** incremental compilation may be broken for this module **

WARNING: eval from module CpuId to ImageQuilting:    
Expr(:call, :cpucycle_id) = Expr(:block, #= Symbol("/home/juliohm/.julia/packages/CpuId/LfVX/src/CpuId.jl"):930 =#, Expr(:call, :rdtscp))
  ** incremental compilation may be broken for this module **
m-j-w commented 6 years ago

Not sure what to do about the second part, but I'll update to remove the syntax warnings.

juliohm commented 6 years ago

Any progress on this? No rush, just asking because I am also struggling to update packages to Julia v1.0.

m-j-w commented 6 years ago

@juliohm Would you please check whether this is still an issue after #31 ?

juliohm commented 6 years ago

I still get this warning @m-j-w from every package depending on CpuId.jl, which is mysterious:

WARNING: eval from module CpuId to ImageInpainting:    
Expr(:call, :cpucycle) = Expr(:block, #= Symbol("/home/juliohm/.julia/packages/CpuId/ARLYE/src/CpuId.jl"):1007 =#, Expr(:call, :rdtsc))
  ** incremental compilation may be broken for this module **

WARNING: eval from module CpuId to ImageInpainting:    
Expr(:call, :cpucycle_id) = Expr(:block, #= Symbol("/home/juliohm/.julia/packages/CpuId/ARLYE/src/CpuId.jl"):1012 =#, Expr(:call, :rdtscp))
  ** incremental compilation may be broken for this module **
juliohm commented 6 years ago

The issue is being discussed here: https://github.com/JuliaLang/julia/issues/29059

juliohm commented 6 years ago

Please feel free to tag a new version of the package. After the PR by @miguelraz , it should be warning-free in Julia v1.0.