Fixes for 1.0 - Githubissues

m-j-w / CpuId.jl

Ask the CPU for cache sizes, SIMD feature support, a running hypervisor, and more.

Other

54 stars 10 forks source link

Fixes for 1.0 #31

Closed miguelraz closed 6 years ago

miguelraz commented 6 years ago

This PR looks to upgrade CpuId.jl to 1.0 We have

cleaned up the travis and appveyor scripts
fixed a deprecation call of & in cpuid not having parenthesis.
tries to fix #30

miguelraz commented 6 years ago

Should we turn on Travis as well in the repo @m-j-w ?

m-j-w commented 6 years ago

@miguelraz Yes, please. I already merged this PR.

m-j-w commented 6 years ago

@miguelraz So the errors from appveyer are related to the failing test script?! What do I do about that?

echo "%JL_TEST_SCRIPT%"
"using Pkg; Pkg.test(coverage=true)"
C:\julia\bin\julia -e "%JL_TEST_SCRIPT%"
   Testing CpuId
 Resolving package versions...
ERROR: LoadError: ArgumentError: Package Test not found in current path:
- Run `Pkg.add("Test")` to install the Test package.

I have idea how to solve this.

miguelraz commented 5 years ago

I think it is best to ask on the #upgradathon slack channel for some pointers.