add some explicit precompile statements for Julia v1.9 and newer

m-j-w / CpuId.jl

Ask the CPU for cache sizes, SIMD feature support, a running hypervisor, and more.

Other

54 stars 10 forks source link

add some explicit precompile statements for Julia v1.9 and newer #57

Closed ranocha closed 12 months ago

ranocha commented 1 year ago

This fixes the remaining compilation time when using CPUSummary after https://github.com/JuliaSIMD/CPUSummary.jl/pull/21

ranocha commented 1 year ago

@m-j-w bump

ranocha commented 1 year ago

@m-j-w bump

m-j-w commented 1 year ago

I'll fix fix this on the weekend.

ranocha commented 1 year ago

Great, thanks!

ranocha commented 1 year ago

@m-j-w Bump

ranocha commented 12 months ago

@m-j-w Bump

chriselrod commented 12 months ago

@ranocha Maybe we should copy this code with attribution and drop the dependency? Feel free to make such a PR.

ranocha commented 12 months ago

Maybe we should copy this code with attribution and drop the dependency? Feel free to make such a PR.

Seems reasonable to go forward in CPUSummary.jl. Currently, the following functions of CpuId.jl are used directly there:

cpucores()
cachesize()
cacheinclusive()
cachelinesize()

In CpuId.jl, these functions call (at least) the additional functions

hasleaf(leaf)
cpuid(leaf, subleaf)
cpufeature(TOPX) with TOPX::CpuFeature
_throw_unsupported_leaf(std_leaf)
__cachesize_level(leaf,zero(UInt32))

This seems to be already a substantial part of CpuId.jl. Thus, it may be easier to fork the project and continue it as CpuId2.jl or something like this. What do you think, @chriselrod?

@m-j-w If you do not have the bandwidth to maintain this package any longer, would you mind transferring it so that we can take over? Otherwise, we will probably continue with one of the approaches listed above.

chriselrod commented 12 months ago

This seems to be already a substantial part of CpuId.jl. Thus, it may be easier to fork the project and continue it as CpuId2.jl or something like this. What do you think, @chriselrod?

Yes, easier to fork than copy most of the repo. Then the connection to the original is more clear, and you also get the unit tests.

m-j-w commented 12 months ago

@ranocha @chriselrod Indeed my time to maintain this is currently strongly limited. If you know an alternative maintainer or organisation I'm probably happy to transfer.

Alternatively, I can add you as collaborator.

m-j-w commented 12 months ago

However, I merged and created the new release, though.

ranocha commented 12 months ago

@m-j-w Great, thanks a lot!

@chriselrod What about transferring this to JuliaSIMD (and adding me as a maintainer for the repo there)?