search

m-jahn / WeightedTreemaps

Create Voronoi and Sunburst Treemaps from Hierarchical data
GNU General Public License v3.0
47 stars 9 forks source link

GH actions fails to build package on macOS and windows due to different errors #18

Closed m-jahn closed 4 years ago

m-jahn commented 4 years ago

On windows-latest:

* checking whether package 'SysbioTreemaps' can be installed ... WARNING
Found the following significant warnings:
  voronoiDiagram.cpp:72:34: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses]
  voronoiDiagram.cpp:157:36: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses]
  voronoiDiagram.cpp:192:27: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses]

On macOS-latest:

File png/logo.png not found in resource path
Error: Error: processing vignette 'README.Rmd' failed with diagnostics:
pandoc document conversion failed with error 99
--- failed re-building ‘README.Rmd’

-On windows it complains about a syntactic problem with the C++ core function -On Mac OS the relative path to the vignettes/png folder is a problem as it gets not recognized (by pandoc?)

m-jahn commented 4 years ago

commit 77e349f solves the 2nd issue with building on MacOS.

m-jahn commented 4 years ago

The two commits fixed the warnings on both OS's.