search

m-jahn / WeightedTreemaps

Create Voronoi and Sunburst Treemaps from Hierarchical data
GNU General Public License v3.0
47 stars 9 forks source link

bug in the size! #25

Closed mir1998 closed 2 years ago

mir1998 commented 2 years ago

I'm using the weightedtreemaps package to visualize a few datasets of ~30 rows I have 2 problems:

  1. many times the rstudio crushes in the middle (until I find a specific seed or choose a high error_tol)
  2. the cell sizes doesnt correlate with the weights of my data if you have any suggestions I will reallt appericiate it. thanks
m-jahn commented 2 years ago

Can you try two things:

  1. reinstall the latest version of WeightedTreemaps from github using devtools::install_github()? I recently introduced a change in how the algorithm converges to the best solution, and this caused many problems. I have reverted to the previous version and it should be stable for data of all sizes
  2. post a reproducible example for your problem in 2, that means your code, and the map it produced. Otherwise I can not look into the problem
m-jahn commented 2 years ago

Did this solve the problem? Without further information I will close this issue.

mir1998 commented 2 years ago

I'm working on reinstalling the package I hope to update you today many thanks Miriam

On Thu, Feb 24, 2022 at 10:30 AM Michael Jahn @.***> wrote:

Did this solve the problem? Without further information I will close this issue.

— Reply to this email directly, view it on GitHub https://github.com/m-jahn/WeightedTreemaps/issues/25#issuecomment-1049609150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIDUICFEH7MSPSNIV2G2EPDU4XUBDANCNFSM5PDSDFPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

mir1998 commented 2 years ago

what is the ideal rstudio version for this package? many thanks Miriam

On Thu, Feb 24, 2022 at 11:41 AM Miriam Elbaz @.***> wrote:

I'm working on reinstalling the package I hope to update you today many thanks Miriam

On Thu, Feb 24, 2022 at 10:30 AM Michael Jahn @.***> wrote:

Did this solve the problem? Without further information I will close this issue.

— Reply to this email directly, view it on GitHub https://github.com/m-jahn/WeightedTreemaps/issues/25#issuecomment-1049609150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIDUICFEH7MSPSNIV2G2EPDU4XUBDANCNFSM5PDSDFPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

m-jahn commented 2 years ago

I'm running Rstudio 1.4.1717, but it should not make much of a difference. What could be useful is to update your R packages. This package is tested against the latest major version of R, 4.0.

mir1998 commented 2 years ago

I updated now my r version to 4.1.2 and I have problems with the package installation Will try now with your version

On Thu, Feb 24, 2022, 12:29 Michael Jahn @.***> wrote:

I'm running Rstudio 1.4.1717, but it should not make much of a difference. What could be useful is to update your R packages. This package is tested against the latest major version of R, 4.0.

— Reply to this email directly, view it on GitHub https://github.com/m-jahn/WeightedTreemaps/issues/25#issuecomment-1049710953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIDUICCSXZKNASW3TTULJR3U4YCAJANCNFSM5PDSDFPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

m-jahn commented 2 years ago

I don't think the Rstudio version makes a difference. What errors are you getting? It would be most helpful if you just paste the ouptput from your console here.

mir1998 commented 2 years ago

Hi I've fixed it and reinstalled the latest version, now the package works much better thank you for this wonderful package and for your kind help Miriam

On Thu, Feb 24, 2022 at 12:40 PM Michael Jahn @.***> wrote:

I don't think the Rstudio version makes a difference. What errors are you getting? It would be most helpful if you just paste the ouptput from your console here.

— Reply to this email directly, view it on GitHub https://github.com/m-jahn/WeightedTreemaps/issues/25#issuecomment-1049721782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIDUICEEN3FZ3LLGRXQVCDTU4YDK5ANCNFSM5PDSDFPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

mir1998 commented 2 years ago

when I run with mclapply the rstudio still crushes sometimes

On Thu, Feb 24, 2022 at 4:32 PM Miriam Elbaz @.***> wrote:

Hi I've fixed it and reinstalled the latest version, now the package works much better thank you for this wonderful package and for your kind help Miriam

On Thu, Feb 24, 2022 at 12:40 PM Michael Jahn @.***> wrote:

I don't think the Rstudio version makes a difference. What errors are you getting? It would be most helpful if you just paste the ouptput from your console here.

— Reply to this email directly, view it on GitHub https://github.com/m-jahn/WeightedTreemaps/issues/25#issuecomment-1049721782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIDUICEEN3FZ3LLGRXQVCDTU4YDK5ANCNFSM5PDSDFPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

m-jahn commented 2 years ago

maybe you can share a reproducible example...