m-jahn / WeightedTreemaps

Create Voronoi and Sunburst Treemaps from Hierarchical data
GNU General Public License v3.0
47 stars 9 forks source link

Error in install the package #35

Closed msgoussi closed 1 year ago

msgoussi commented 1 year ago

Hi... When i run this code devtools::install_github("m-jahn/WeightedTreemaps"), I get this error

devtools::install_github("m-jahn/WeightedTreemaps") Downloading GitHub repo m-jahn/WeightedTreemaps@HEAD ── R CMD build ─────────────────────────────────────────────────────────────────────────────────────── ✔ checking for file 'C:\Windows\Temp\Rtmp2xUHqk\remotesef876a23625\m-jahn-WeightedTreemaps-614e114/DESCRIPTION' (773ms) ─ preparing 'WeightedTreemaps': (348ms) ✔ checking DESCRIPTION meta-information ... ─ cleaning src ─ checking for LF line-endings in source and make files and shell scripts ─ checking for empty or unneeded directories ─ building 'WeightedTreemaps_0.1.1.tar.gz'

compilation terminated. make: *** [C:/ERS_PR~1/R/R-43~1.1/etc/x64/Makeconf:272: voronoiDiagram.o] Error 1 ERROR: compilation failed for package 'WeightedTreemaps'

m-jahn commented 1 year ago

Hey. You seem to be compiling on Windows. I can't reproduce this error because I'm using Linux, however the package builds fine in github actions automatic test even on Windows. The error message is unfortunately not very informative. Can you check that you have the necessary requirements? The package needs a C++ 17 compiler such as gcc. Also you might want to check if the required dependencies are correctly installed, such as R packages bh, Rcpp, and RcppCGAL which is currently installed from github instead of CRAN --> see https://github.com/ericdunipace/RcppCGAL Maybe try to install this particular package separately and see if it builds?

m-jahn commented 1 year ago

Correction: the package did not install correctly on GH actions on Windows. See log here: https://github.com/m-jahn/WeightedTreemaps/actions/runs/6143193156/job/16666179017

The package stops building when installing the remote dependency RcppCGAL, just as I suspected. I recommend to you installing it manually, and see what happens there. You can paste the error message here if it fails, I'd be curious to see that.

m-jahn commented 1 year ago

BTW in the mean time you can use a Shiny App to plot your data --> https://m-jahn.shinyapps.io/ShinyTreemaps/

msgoussi commented 1 year ago

Hi I figured it out after re installing BH, Rcpp, and RcppCGAL. I ran this code (according to instructions in https://github.com/ericdunipace/RcppCGAL) library(RcppCGAL) Performing one-time download of CGAL from https://github.com/CGAL/cgal/releases/download/v5.6/CGAL-5.6.tar.xz

once i loaded the library RcppCGAL, and new folder was created (R\R-4.3.1\library\RcppCGAL\include\CGAL)

Then i run

devtools::install_github("m-jahn/WeightedTreemaps")

i succeeded to install weightedtreemap

m-jahn commented 1 year ago

great, will close this now.