Bandcamp Issues- Invisible Song Bar

m-khvoinitsky / dark-background-light-text-extension

Firefox addon that turns every page colors into "light text on dark background"

Mozilla Public License 2.0

361 stars 28 forks source link

Bandcamp Issues- Invisible Song Bar #157

Open EnsignEpic opened 6 years ago

EnsignEpic commented 6 years ago

This error appears to happen on any artist who uses a white foreground, but this causes the Stylesheet processor to make the song's time bar invisible, including its border. This does not happen for any artist who uses any other color, but as so many default to using the white foreground, this issue happens a lot. Here's a quick before and after.

m-khvoinitsky commented 6 years ago

Clickable link https://braxtonburks.bandcamp.com/album/bacon-man-an-adventure-original-game-soundtrack

Possible solution:

--- a/methods/stylesheet-color-processor.js
+++ b/methods/stylesheet-color-processor.js
@@ -34,6 +34,7 @@ const preserve_background_color = [
     '.ytp-load-progress',
     '.ytp-progress-list',
     '.paper-toggle-button',
+    '.inline_player .thumb', // #157
 ];

 const remove_background_image = [

Needs to be investigated whether it would cause more issues rather than solve.