search

m-khvoinitsky / dark-background-light-text-extension

Firefox addon that turns every page colors into "light text on dark background"
Mozilla Public License 2.0
361 stars 27 forks source link

Invert mode adding vertical offset when displaying an image #272

Closed eneiss closed 4 years ago

eneiss commented 4 years ago

I noticed this bug a few weeks ago : whenever I display an image (JPG or PNG) in a Firefox tab using the "invert" mode of the add-on, it has a negative vertical offset hiding a part of it, but can't be scrolled. The offset seems to be so that only the lower half of the image is displayed. This doesn't happen with the other modes, or when the add-on is disabled.

I am using Firefox 79.0 (64 bits), on Windows 10, and the 0.7.2 release of the add-on.

Screenshots of the issue :

Image used : GitHub logo (png) inverted_mode_offset other_mode_no_offset Image used : random grid (jpg) jpg_offset jpg full

m-khvoinitsky commented 4 years ago

Try to enable options specified in https://github.com/m-khvoinitsky/dark-background-light-text-extension/issues/126#issue-276778271. That's an old issue (and not the only) with "old" Invert method which is used when backdrop-filter is not supported. Please, try and report the result.

eneiss commented 4 years ago

It fixed the offset issue, but now the background color is almost white. I guess this is how the invert mode is supposed to work when the default background color is dark, so it doesn't really matter. Thanks for your help ! 😄