Open cjyar opened 4 years ago
re: 1) https://github.com/m-lab/alertmanager-github-receiver#create-github-access-token outlines what permissions are needed for the access token. Unfortunately, "push" is not mentioned on the token allocation page. A note in our readme that points to the link you put here would be welcome.
re: 2) yes, if the client doesn't have sufficient permissions it should not create any issues. That addresses 3) also.
According to https://developer.github.com/v3/issues/#create-an-issue:
Scenario:
alertmanager-github-receiver
is running as a user without permission to push to a repo.alertmanager-github-receiver
receives it, it checks to see if the issue already exists. It searches based on labels first, so it doesn't find the existing issue.alertmanager-github-receiver
creates a duplicate issue.It seems like there are a few things we should/could do:
push
permissions for the service account.