search

m-lab / alertmanager-github-receiver

Prometheus Alertmanager webhook receiver that creates GitHub issues from alerts
Apache License 2.0
48 stars 23 forks source link

Added a -label-on-resolved flag. #38

Closed cjyar closed 4 years ago

cjyar commented 4 years ago

This addresses #37.

This change is Reviewable

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 126

Totals Coverage Status
Change from base Build 122: 0.0%
Covered Lines: 368
Relevant Lines: 368
💛 - Coveralls
cjyar commented 4 years ago

@stephen-soltesz Ready for re-review.

cjyar commented 4 years ago

Now I'm embarrassed. It looks like the GitHub API for deleting a label from an issue isn't idempotent, so this code doesn't actually work. :(

I was deploying it in our test instance while you were merging; too slow on this end.

I'll work on a fix.

stephen-soltesz commented 4 years ago

Oh no! Thanks for noticing quickly.