add verbose flag to prevent logging authtoken

m-lab / alertmanager-github-receiver

Prometheus Alertmanager webhook receiver that creates GitHub issues from alerts

Apache License 2.0

48 stars 23 forks source link

add verbose flag to prevent logging authtoken #44

Closed LenaHoinkis closed 4 years ago

LenaHoinkis commented 4 years ago

Currently all arguments get logged including the authorization token. Even if a authtokenFile is given it will print the token. For security reasons I would suggest to only print the argument logs, if the verbose parameter is set.

This change is

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 135

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 129:	0.0%
Covered Lines:	378
Relevant Lines:	378

💛 - Coveralls

stephen-soltesz commented 4 years ago

I've merged https://github.com/m-lab/alertmanager-github-receiver/pull/46

I'll tag a new version next. I'll close this PR because I believe #46 addresses the same requirement.

Thank you for your help!