Feature/template improvements

m-lab / alertmanager-github-receiver

Prometheus Alertmanager webhook receiver that creates GitHub issues from alerts

Apache License 2.0

48 stars 23 forks source link

Feature/template improvements #54

Closed aorfanos closed 1 year ago

aorfanos commented 3 years ago

Allows use of a custom alert message template file.

Example invocation would be: -alert-template-file=alertfile.md .

I have commented out Test_formatIssueBody because I'm still working my way to make it work.

This change is

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 171

17 of 19 (89.47%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 99.516%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
alerts/handler.go	7	9	77.78%
<!--	Total:	17	19	89.47%	-->

Totals
Change from base Build 162:	-0.5%
Covered Lines:	411
Relevant Lines:	413

💛 - Coveralls

Limess commented 2 years ago

We just started looking at using this project, this feature is a must have though - it'd be great to see this merged and released so we don't have to build and maintain a fork.

stephen-soltesz commented 1 year ago

Thank you for this change @aorfanos - I'm taking a look now. I'm not sure how we missed it this long.

aorfanos commented 1 year ago

I've forgotten about it as well - better late than never 😄

stephen-soltesz commented 1 year ago

@aorfanos thank you for this change - the logic here was the basis of https://github.com/m-lab/alertmanager-github-receiver/pull/59 now merged (your contribution is acknowledged in the commit). We'll prepare a new release this week. I'll close this PR since the functionality is now merged to the main branch.