m-lab / annotation-service

Annotation integration service for M-Lab data
Apache License 2.0
3 stars 5 forks source link

Asn annotator - first phase #215

Open zkauker opened 5 years ago

zkauker commented 5 years ago

To make sure that I won't impact the current codebase I decided that in the first phase I copy-paste the implementations which are needed but cannot be reused as it is right now (package private functions for building the IPNode list and then doing a binary search on that). I'm going to continue with externalizing this logic.

TODOs:


This change is Reviewable

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1998


Changes Missing Coverage Covered Lines Changed/Added Lines %
loader/loader.go 0 4 0.0%
geoloader/geoloader_asn.go 0 27 0.0%
<!-- Total: 7 38 18.42% -->
Files with Coverage Reduction New Missed Lines %
api/v2/api-v2.go 1 75.31%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 1995: -1.2%
Covered Lines: 783
Relevant Lines: 1503

💛 - Coveralls