Open zkauker opened 5 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
loader/loader.go | 0 | 4 | 0.0% | ||
geoloader/geoloader_asn.go | 0 | 27 | 0.0% | ||
<!-- | Total: | 7 | 38 | 18.42% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
api/v2/api-v2.go | 1 | 75.31% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 1995: | -1.2% |
Covered Lines: | 783 |
Relevant Lines: | 1503 |
To make sure that I won't impact the current codebase I decided that in the first phase I copy-paste the implementations which are needed but cannot be reused as it is right now (package private functions for building the
IPNode
list and then doing a binary search on that). I'm going to continue with externalizing this logic.TODOs:
mlab-sandbox
environment -> should move the necessary files tomlab-test
'sdownloader-mlab-test
bucket to make sure that the unit tests will work with the CI/CD toolThis change is