coveralls
commented
5 years ago Pull Request Test Coverage Report for Build 2135
- 12 of 22 (54.55%) changed or added relevant lines in 4 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage increased (+1.4%) to 54.042%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| geoloader/geoloader.go | 0 | 2 | 0.0% | ||
| loader/csv-reader.go | 9 | 12 | 75.0% | ||
| geolite2v2/geo-ip-loc-loader.go | 1 | 6 | 16.67% | ||
| <!-- | Total: | 12 | 22 | 54.55% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| geolite2v2/geo-ip-loc-loader.go | 1 | 70.0% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 2133: | 1.4% |
| Covered Lines: | 1063 |
| Relevant Lines: | 1967 |
The migrates geolite2 tests to geolite2v2. Also moves some code from prod to test and some minor refactorings. There is currently one broken migrated test, which is very strange. Working on diagnosing.
This change is