search

m-lab / annotation-service

Annotation integration service for M-Lab data
Apache License 2.0
3 stars 5 forks source link

Metrics are poorly named #266

Open pboothe opened 4 years ago

pboothe commented 4 years ago

We named the metrics for this server before we had knowledge about what Prometheus names should look like. Unsurprisingly, we got it wrong a bunch.

Metrics are recommended to all be lowercase, and prometheusx.promlint in http://github.com/m-lab/go/ will actually provide compile-time checks of name quality.

The metric that caused this issue to be created was: annotator_Request_Response_Time_Summary, about which the linter says:

Bad metric annotator_Request_Response_Time_Summary: metric name should not include type 'summary'
pboothe commented 4 years ago

Remediated the build breakage in #267 .

Still need to fix the underlying problem.