search

m-lab / etl-gardener

Gardener provides services for maintaining and reprocessing mlab data.
Apache License 2.0
13 stars 5 forks source link

Eliminate use of _DOCKER_TAG substitution #336

Closed stephen-soltesz closed 2 years ago

stephen-soltesz commented 2 years ago

The _DOCKER_TAG substitution was originally intended to allow production images to use the tag name as the image tag, e.g. gcr.io/mlab-oti/etl-gardener:prod-v2.4.2, however this does not work as intended because the kubernetes configuration unconditionally uses the COMMIT_SHA as the image tag.

To eliminate the unnecessary indirection and different handling in staging and production, this change removes the DOCKER_TAG in favor of using COMMIT_SHA directly.

After merge, the _DOCKER_TAG substitution in the etl-gardener cloudbuild trigger configuration should be removed manually.

This change is Reviewable

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 60.402% when pulling fbb7273c08fbe867701ad373fd8ab46990303873 on sandbox-soltesz-rmdockertag into b080455648c2b445148a55ef289ace7184c55098 on master.