search

m-lab / etl-gardener

Gardener provides services for maintaining and reprocessing mlab data.
Apache License 2.0
13 stars 5 forks source link

Cleanup: Replace ad-hoc env lookups with explicit flags and parameters #372

Closed stephen-soltesz closed 2 years ago

stephen-soltesz commented 2 years ago

This change is a cleanup of v2 gardener to consistently use flags to provide configuration information. Previously, gardener used a mixture of flags and environment variables for configuration of the service and the ops package.

This change replaces all v2 environmental dependencies with explicit flags or function parameters. Now, any value used by the v2 system is provided by a command line flag. Because gardener uses flagx.ArgsFromEnv any flag value can also be specified using the environment.

This change does not change default behavior.

This change is Reviewable

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-0.1%) to 61.144% when pulling 086592fc2315c146605722b331fd1538efecc6d6 on sandbox-soltesz-env into cb8c8ab0b5d347acbe1eb56f72e4762024ed1f03 on master.