Closed stephen-soltesz closed 2 years ago
client/v2/client.go
line 104 at r1 (raw file):
} defer resp.Body.Close() return ioutil.ReadAll(resp.Body)
The ioutil package was deprecated in Go 1.16 (details: https://go.dev/doc/go1.16), so I suggest to change this to io.ReadAll().
client/v2/client_test.go
line 110 at r1 (raw file):
c := NewJobClient(*u) if tt.corruptTransport { // Corrupt the default http transport so that making the reqeust fails.
nit: s/reqeust/request/
Thank you!
This change adds a new all-inclusive v2 client implementation for accessing the gardener Jobs API resources.
The previous jobs API was accessed using a mixture of logic across three packages:
The new version of the Jobs API creates a dedicated client and encapsulates all requests to the v2 API.
Part of:
This change is