Remove tracker.NewJob and add jobtest.NewJob for unit tests

m-lab / etl-gardener

Gardener provides services for maintaining and reprocessing mlab data.

Apache License 2.0

13 stars 5 forks source link

Remove tracker.NewJob and add jobtest.NewJob for unit tests #391

Closed stephen-soltesz closed 1 year ago

stephen-soltesz commented 1 year ago

This change removes a 'DEPRECATED' function from tracker that was only used in unit tests and non production binaries (cmd/load, cmd/copy). Instead, the functionality of NewJob is added to a new jobtest package and all references in unit tests are updated throughout.

This change is a cleanup in preparation for the final change to complete https://github.com/m-lab/etl-gardener/issues/349

This change is

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3395

8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 73.05%

Files with Coverage Reduction	New Missed Lines	%
tracker/job.go	8	83.03%
<!--	Total:	8		-->

Totals
Change from base Build 3383:	-0.3%
Covered Lines:	1583
Relevant Lines:	2167

💛 - Coveralls

SaiedKazemi commented 1 year ago

Looks good to me, but could you please add how you tested these changes to your commit message?

stephen-soltesz commented 1 year ago

Thank you! Added to squash & merge commit message.