Use LocalNamedSaver and DateIterators for job.Service - Githubissues

m-lab / etl-gardener

Gardener provides services for maintaining and reprocessing mlab data.

Apache License 2.0

13 stars 5 forks source link

Use LocalNamedSaver and DateIterators for job.Service #397

Closed stephen-soltesz closed 1 year ago

stephen-soltesz commented 1 year ago

This change migrates the job.Service implementation to use the daily and historical job.DateIterators from https://github.com/m-lab/etl-gardener/pull/395 . The names of locally saved persistence is now explicit within cmd/gardener. The current names preserve backward compatibility with the previous implementation and can be migrated to normalized names in the future. In total, this change dramatically simplifies the job.Service implementation.

Tested locally and in sandbox overnight.

This change is a continuation of work toward https://github.com/m-lab/etl-gardener/issues/349

This change is

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3442

26 of 26 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 73.865%

Totals
Change from base Build 3439:	-0.2%
Covered Lines:	1546
Relevant Lines:	2093

💛 - Coveralls

stephen-soltesz commented 1 year ago

I'd like this to run overnight. And, I think additional scenario unit testing would be welcome. Sharing early for feedback.

stephen-soltesz commented 1 year ago

Appears to be WAI in sandbox. Merging now.