m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Add ServerX and ClientX annotation records to tcpinfo and traceroute schemas #1004

Closed stephen-soltesz closed 3 years ago

stephen-soltesz commented 3 years ago

This change continues changes to prepare for the annotation export process. This change adds the ServerX and ClientX records to the tcpinfo and traceroute schemas to support the annotation export process by simplifying the export query by using the uuid-annotator schema directly (rather than requiring the query to perform a complex translation at export time).

This change completes all known dependencies for sidestream, ndt.web100, traceroute, and tcpinfo annotation export.


This change is Reviewable

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 6521


Changes Missing Coverage Covered Lines Changed/Added Lines %
schema/pt_schema.go 0 8 0.0%
schema/tcpinfo.go 0 8 0.0%
<!-- Total: 6 22 27.27% -->
Files with Coverage Reduction New Missed Lines %
schema/pt_schema.go 1 0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 6519: -0.1%
Covered Lines: 3473
Relevant Lines: 5562

💛 - Coveralls
stephen-soltesz commented 3 years ago

FYI: @gfr10598 this is the change to add a new annotation record to tcpinfo and traceroute schemas to support the export process.

stephen-soltesz commented 3 years ago

Merging pending unit tests in the future. Will respond to comments soon.