m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Complete unit tests for ServerX and ClientX records in tcpinfo and pt parsers #1007

Closed stephen-soltesz closed 3 years ago

stephen-soltesz commented 3 years ago

This change completes the unit tests omitted from https://github.com/m-lab/etl/pull/1004

This change moves the fakeAnnotator type from the tcpinfo_test.go file to the common parser_test.go for use by multiple parsers.

This change adds ServerX and ClientX value tests to the tcpinfo parser. This change adds ServerX and ClientX value tests to the pt parser for .paris and .jsonl file types.

Because correct annotations require well formatted archive URLs, additional changes ensure that valid URLs are provided to unit tests.


This change is Reviewable

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 6544


Files with Coverage Reduction New Missed Lines %
active/poller.go 3 67.86%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 6540: 0.09%
Covered Lines: 3507
Relevant Lines: 5579

💛 - Coveralls
stephen-soltesz commented 3 years ago

Thank you!