m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Tweak slice allocation to improve pcap parsing performance. #1034

Closed gfr10598 closed 2 years ago

gfr10598 commented 2 years ago

This is a minor tweak, but useful to get a better baseline before adding a lot more code.

It also adds a better benchmark, that includes accounting for the packets/op, so that it is easier to estimate time and memory allocated per packet.


This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 6948


Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/pcap.go 14 18 77.78%
<!-- Total: 14 18 77.78% -->
Totals Coverage Status
Change from base Build 6945: 0.03%
Covered Lines: 3856
Relevant Lines: 6002

💛 - Coveralls
stephen-soltesz commented 2 years ago

Closing old PR - and referencing the notes from this change in https://github.com/m-lab/etl/issues/1085