m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Rename metric to etl_task_total #1040

Closed cristinaleonr closed 2 years ago

cristinaleonr commented 2 years ago

Rename the etl_task_count metric to etl_task_total to honor prometheus best practices for metric naming: https://prometheus.io/docs/practices/naming/.

This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 7049


Changes Missing Coverage Covered Lines Changed/Added Lines %
task/task.go 0 1 0.0%
cmd/etl_worker/etl_worker.go 0 3 0.0%
worker/worker.go 3 12 25.0%
<!-- Total: 3 16 18.75% -->
Files with Coverage Reduction New Missed Lines %
active/active.go 4 88.54%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 7029: -0.07%
Covered Lines: 3840
Relevant Lines: 5986

💛 - Coveralls