m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Add field descriptions for scamper1 datatype #1057

Closed SaiedKazemi closed 2 years ago

SaiedKazemi commented 2 years ago

This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 7201


Files with Coverage Reduction New Missed Lines %
active/active.go 4 88.54%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 7197: -0.03%
Covered Lines: 3902
Relevant Lines: 6057

💛 - Coveralls
SaiedKazemi commented 2 years ago

@cristinaleonr I forgot to mention in the pull request that the file isn't fully complete yet because I couldn't find descriptions for everything in samper header files. Therefore, please consider this as the first step toward providing descriptions for all fields as we learn more ourselves. @stephen-soltesz Just FYI...

SaiedKazemi commented 2 years ago

schema/descriptions/Scamper1Row.yaml, line 70 at r1 (raw file):

Previously, cristinaleonr (Cristina Leon) wrote…
What is "unresp."?

I think it is short for unresponsive, which I changed to.

SaiedKazemi commented 2 years ago

schema/descriptions/Scamper1Row.yaml, line 74 at r1 (raw file):

Previously, cristinaleonr (Cristina Leon) wrote…
Should this be capitalized like the others?

Done.

SaiedKazemi commented 2 years ago

schema/descriptions/Scamper1Row.yaml, line 48 at r1 (raw file):

Previously, cristinaleonr (Cristina Leon) wrote…
Used*

Done.

SaiedKazemi commented 2 years ago

schema/descriptions/Scamper1Row.yaml, line 132 at r1 (raw file):

Previously, cristinaleonr (Cristina Leon) wrote…
Should this be "ICMP code **of** the reply."?

Done.

SaiedKazemi commented 2 years ago

Thank you @cristinaleonr for your careful review. I fixed the typos. PTAL.