Closed SaiedKazemi closed 2 years ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
active/active.go | 4 | 88.54% | ||
<!-- | Total: | 4 | --> |
Totals | |
---|---|
Change from base Build 7197: | -0.03% |
Covered Lines: | 3902 |
Relevant Lines: | 6057 |
@cristinaleonr I forgot to mention in the pull request that the file isn't fully complete yet because I couldn't find descriptions for everything in samper header files. Therefore, please consider this as the first step toward providing descriptions for all fields as we learn more ourselves. @stephen-soltesz Just FYI...
schema/descriptions/Scamper1Row.yaml, line 70 at r1 (raw file):
What is "unresp."?
I think it is short for unresponsive, which I changed to.
schema/descriptions/Scamper1Row.yaml, line 74 at r1 (raw file):
Should this be capitalized like the others?
Done.
schema/descriptions/Scamper1Row.yaml, line 48 at r1 (raw file):
Used*
Done.
schema/descriptions/Scamper1Row.yaml, line 132 at r1 (raw file):
Should this be "ICMP code **of** the reply."?
Done.
Thank you @cristinaleonr for your careful review. I fixed the typos. PTAL.
This change is![Reviewable](https://reviewable.io/review_button.svg)