m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Update Go version in Dockerfile #1058

Closed cristinaleonr closed 2 years ago

cristinaleonr commented 2 years ago

A lot the project's dependencies were upgraded when we updated to the latest version of ndt-server #1056.

This has caused the Docker build to fail since it some of the new dependencies require a higher version of Go. https://hub.docker.com/repository/registry-1.docker.io/measurementlab/generate-schema-docs/builds/5dba9aee-3d0c-41b0-90e3-2166e489bb19.

Upgrading the Go/Alpine versions in the Dockerfile to be the same as ndt-server fixes this issue https://github.com/m-lab/ndt-server/pull/339. Tested locally with docker build . -t etl.

This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 7207


Files with Coverage Reduction New Missed Lines %
active/active.go 4 88.54%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 7203: -0.07%
Covered Lines: 3902
Relevant Lines: 6057

💛 - Coveralls
cristinaleonr commented 2 years ago

Fyi @SaiedKazemi