Add Gardener v2 parser for switch datatype

m-lab / etl

M-Lab ingestion pipeline

Apache License 2.0

22 stars 7 forks source link

Add Gardener v2 parser for switch datatype #1059

Closed robertodauria closed 2 years ago

robertodauria commented 2 years ago

This PR is a duplicate of #1044, which was reverted in https://github.com/m-lab/etl/pull/1049. The v1 parser has been frozen (https://github.com/m-lab/etl/pull/1051) so that we should now be able to merge this new v2 parser without disrupting v1 parsers.

The only change, other than updating the branch from master, was renaming TestCount -> TestTotal in switch.go since the metric's name has been recently changed.

This change is

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 7212

145 of 223 (65.02%) changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 64.601%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
parser/parser.go	0	2	0.0%
parser/switch.go	145	178	81.46%
schema/switch_schema.go	0	43	0.0%
<!--	Total:	145	223	65.02%	-->

Files with Coverage Reduction	New Missed Lines	%
schema/switch_schema.go	2	0%
<!--	Total:	2		-->

Totals
Change from base Build 7210:	0.1%
Covered Lines:	3982
Relevant Lines:	6164

💛 - Coveralls

stephen-soltesz commented 2 years ago

Part of:

https://github.com/m-lab/etl/issues/1061