m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Only failfast for write errors #1060

Closed cristinaleonr closed 2 years ago

cristinaleonr commented 2 years ago

The failfast option (introduced in https://github.com/m-lab/etl/pull/906) terminates a task when there is any parsing error.

This PR makes this behavior exclusive to write errors.


This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 7227


Changes Missing Coverage Covered Lines Changed/Added Lines %
row/row.go 6 7 85.71%
task/task.go 1 3 33.33%
<!-- Total: 7 10 70.0% -->
Files with Coverage Reduction New Missed Lines %
row/row.go 1 67.11%
task/task.go 1 72.65%
active/active.go 4 88.54%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 7217: 0.002%
Covered Lines: 3981
Relevant Lines: 6170

💛 - Coveralls