Add or update field descriptions for scamper1 datatype

m-lab / etl

M-Lab ingestion pipeline

Apache License 2.0

22 stars 7 forks source link

Add or update field descriptions for scamper1 datatype #1064

Closed SaiedKazemi closed 2 years ago

SaiedKazemi commented 2 years ago

This commit adds (or updates) descriptions for the fields that were not covered in https://github.com/m-lab/etl/pull/1057. Descriptions for raw.{CycleStart,Tracelb,CycleStop} fields are provided by scamper's author Matthew Luckie.

This change is

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 7252

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.587%

Totals
Change from base Build 7246:	0.0%
Covered Lines:	3985
Relevant Lines:	6170

💛 - Coveralls

SaiedKazemi commented 2 years ago

schema/descriptions/Scamper1Row.yaml, line 144 at r1 (raw file):

Previously, cristinaleonr (Cristina Leon) wrote…

Is this the same description as `raw.CycleStart.ID`? Should we add that one, too?

It should be the same. But now that you are asking and I am looking at it in greater detail, I am seeing that it doesn't match scamper source code which describes id as "the cycle id". I need to check this with Matthew.

Thank you for your detailed review.

SaiedKazemi commented 2 years ago

@cristinaleonr PTAL.