m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Add tcpinfo v2 parser #1067

Closed stephen-soltesz closed 2 years ago

stephen-soltesz commented 2 years ago

This change updates the tcpinfo parser to support standard columns for the v2 data pipeline. This change preserves the previous behavior by thinning snapshots 10:1. This change eliminates tcpinfo support for the v1 data pipeline.

This change moves structures previously defined in the tcpinfo.go file to the common schema.go, now used only by v1 datatypes. These structures include ServerInfo, ClientInfo, and ParseInfoV0.

Design:

Part of:

Testing:


This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 7261


Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ndt.go 0 2 0.0%
parser/tcpinfo.go 33 41 80.49%
<!-- Total: 35 45 77.78% -->
Files with Coverage Reduction New Missed Lines %
parser/tcpinfo.go 1 77.04%
schema/schema.go 2 92.59%
active/poller.go 3 64.33%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 7253: 0.7%
Covered Lines: 3972
Relevant Lines: 6084

💛 - Coveralls