Remove v1 logic from etl packages: fake, bq, and related tests - Githubissues

m-lab / etl

M-Lab ingestion pipeline

Apache License 2.0

22 stars 7 forks source link

Remove v1 logic from etl packages: fake, bq, and related tests #1086

Closed stephen-soltesz closed 2 years ago

stephen-soltesz commented 2 years ago

This change completes a TODO from https://github.com/m-lab/etl/pull/1080 in the worker_test.go to use a fakestorage server to make what was previously an "integration" test a standard, in-memory unit test.

This change also removes two packages that are now unnecessary:

bq - which managed inserts into BigQuery tables, via a Put() method
fake - which implemented an in-memory interface of the bq package's Put() method for unit tests.

Part of:

https://github.com/m-lab/etl/issues/1084

This change is

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 7320

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.7%) to 65.542%

Files with Coverage Reduction	New Missed Lines	%
active/active.go	2	90.63%
<!--	Total:	2		-->

Totals
Change from base Build 7318:	-0.7%
Covered Lines:	3631
Relevant Lines:	5540

💛 - Coveralls