coveralls
commented
2 years ago Pull Request Test Coverage Report for Build 7344
- 29 of 37 (78.38%) changed or added relevant lines in 5 files are covered.
- 10 unchanged lines in 3 files lost coverage.
- Overall coverage increased (+2.7%) to 67.183%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| parser/pt.go | 12 | 15 | 80.0% | ||
| parser/ndt.go | 8 | 13 | 61.54% | ||
| <!-- | Total: | 29 | 37 | 78.38% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| parser/pt.go | 1 | 79.55% | ||
| active/active.go | 4 | 88.54% | ||
| parser/ndt.go | 5 | 57.32% | ||
| <!-- | Total: | 10 | --> |
| Totals | |
|---|---|
| Change from base Build 7336: | 2.7% |
| Covered Lines: | 3339 |
| Relevant Lines: | 4970 |
stephen-soltesz
This change eliminates the
row.Annotatableinterface and the dependency onrow.NullAnnotatorfor all schemas.This change also eliminates the v1 parser/base.go interfaces in favor of migrating the v1 types (ndt, pt, and sidestream) to the
row.Baseinterface. While these v1 types and schemas are not yet supported by the parsers, this is an incremental step toward making that possible. The only thing preventing it now is an update to the schema itself to use standard columns and supporting parser changes to use the updated schema.Part of:
This change is