Remove explicit dependencies on the decommissioned annotation-service

m-lab / etl

M-Lab ingestion pipeline

Apache License 2.0

22 stars 7 forks source link

Remove explicit dependencies on the decommissioned annotation-service #1091

Closed stephen-soltesz closed 2 years ago

stephen-soltesz commented 2 years ago

This change removes all explicit dependencies on the annotation-service. Though go.mod still reports an indirect dependency (likely) through uuid-annotator.

To eliminate this dependency for v1 datatypes, we replace references to *api.GeolocationIP and *api.ASData with local struct definitions for LegacyGeolocationIP and LegacyASData.

Part of:

https://github.com/m-lab/etl/issues/1084

This change is

stephen-soltesz commented 2 years ago

@SaiedKazemi would you also take a look? In particular, regarding the handling of the Legacy* structs.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 7369

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 67.191%

Totals
Change from base Build 7367:	0.02%
Covered Lines:	3332
Relevant Lines:	4959

💛 - Coveralls

SaiedKazemi commented 2 years ago

If legacy structs are not used anymore and are also not to be used, can they be commented out?