m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Use ndt5 TCPInfo.MinRTT when available for a.MinRTT summary #1097

Closed stephen-soltesz closed 2 years ago

stephen-soltesz commented 2 years ago

This change updates the ndt5 parser to use the S2C.TCPInfo.MinRTT value when TCPInfo is available rather than the lower-resolution S2C.MinRTT (which was calculated in user-space to mimmic earlier web100 behavior, possibly before TCPInfo.MinRTT was calculated in the Linux kernel). This change includes a new sample ndt result file that includes an TCPInfo record.

Note: this change will apply to all ndt5 measurements since 2020-06-18 to present. The pipeline cycle time is much longer now so this value will not be updated for all historical data for several months. However, daily data will use this update once this change is deployed to production.

Part of:


This change is Reviewable

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 7378


Totals Coverage Status
Change from base Build 7373: 0.2%
Covered Lines: 3342
Relevant Lines: 4967

💛 - Coveralls
stephen-soltesz commented 2 years ago

FYI: @mattmathis PTAL?

stephen-soltesz commented 2 years ago

Thank you!