m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Add capacity to filter select client_name values #1108

Closed stephen-soltesz closed 1 year ago

stephen-soltesz commented 1 year ago

This change adds support for filtering select client_name values from the ndt7 ClientMetadata. This change prevents the value from being published to BigQuery, making the value effectively unsearchable, though it will remain in the underlying raw storage. Since clients optionally provide the client_name value, it is impossible to distinguish between clients that never provided the value or those that have the value filtered without looking at the raw data directly.


This change is Reviewable

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 7433


Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ndt7_result.go 32 35 91.43%
<!-- Total: 32 35 91.43% -->
Files with Coverage Reduction New Missed Lines %
active/active.go 2 90.63%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 7429: 0.2%
Covered Lines: 3351
Relevant Lines: 4973

💛 - Coveralls
stephen-soltesz commented 1 year ago

Obsolete.