coveralls
commented
3 years ago Pull Request Test Coverage Report for Build 6296
- 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
- 41 unchanged lines in 6 files lost coverage.
- Overall coverage increased (+0.6%) to 67.01%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| schema/schema.go | 6 | 7 | 85.71% | ||
| <!-- | Total: | 6 | 7 | 85.71% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| schema/schema.go | 1 | 92.59% | ||
| active/active.go | 2 | 89.89% | ||
| schema/tcpinfo.go | 2 | 45.68% | ||
| schema/annotation.go | 9 | 0% | ||
| schema/ndt7_result.go | 9 | 0% | ||
| schema/ndt5_result.go | 18 | 0% | ||
| <!-- | Total: | 41 | --> |
| Totals | |
|---|---|
| Change from base Build 6272: | 0.6% |
| Covered Lines: | 3055 |
| Relevant Lines: | 4559 |
This change removes go-bindata and bindata.go from m-lab/etl -- this integration has caused more pain and inconvenience than originally intended or expected. By removing the bindata commands that depend on the location of the schema descriptions (update-schema, generate_schema_docs, etc) must ensure that the
-schema.descriptionsflag is set appropriately. Default behavior is to print a warning if schema descriptions are not found.Fixes https://github.com/m-lab/etl/issues/966
This change is