m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Start parsing ".json" files #974

Closed SaiedKazemi closed 3 years ago

SaiedKazemi commented 3 years ago

Starting with this PR, ".json" files for the new "traceroute3" datatype are no longer ignored.

This PR includes some improvements to the testing code of the "parser" package. Specifically, super long lines (some greater than 6,000 characters!) that are used to initialize a string variable are replaced by reading the contents of a file. Also, temporary files created during package testing are now deleted when the test finishes.

The changes were tested as follows: $ git status -s $ go test ./... $ git status -s


This change is Reviewable

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 6336


Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/pt.go 1 2 50.0%
<!-- Total: 1 2 50.0% -->
Totals Coverage Status
Change from base Build 6332: 0.0%
Covered Lines: 3573
Relevant Lines: 5326

💛 - Coveralls