m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

remove etl-schema submodule #979

Closed gfr10598 closed 3 years ago

gfr10598 commented 3 years ago

This just removes the etl-schema submodule.

Testing: Check for references: find . -type f | xargs grep sync_tables find . -type f | xargs grep m-lab/etl-schema (There are still some references in .git/modules but those are local files)

Run unit tests. Verify build https://pantheon.corp.google.com/cloud-build/builds;region=global/1de36a06-955f-4ee9-9429-52e3a02bc060?project=mlab-sandbox Confirm operation in sandbox: https://cloudlogging.app.goo.gl/6h8L3DJccr2i8Cvv7


This change is Reviewable

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 6368


Files with Coverage Reduction New Missed Lines %
active/active.go 4 87.64%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 6350: -0.2%
Covered Lines: 3440
Relevant Lines: 5140

💛 - Coveralls
gfr10598 commented 3 years ago

FYI, problem with tables was resolved by deleting tables and re-building sandbox-master. https://github.com/m-lab/etl/pull/977