m-lab / etl

M-Lab ingestion pipeline
Apache License 2.0
22 stars 7 forks source link

Add method for GCS Path for DataPath type #993

Closed stephen-soltesz closed 3 years ago

stephen-soltesz commented 3 years ago

This change adds a new helper method to recover the GCS "Path" portion of the URI. A common use case is extracting this path. As a result, this change reduces some ad-hoc parsing of the URI in favor of placing all URI parsing in the etl.DataPath type.


This change is Reviewable

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 6455


Changes Missing Coverage Covered Lines Changed/Added Lines %
etl/globals.go 8 11 72.73%
storage/rowwriter.go 0 3 0.0%
<!-- Total: 13 19 68.42% -->
Totals Coverage Status
Change from base Build 6450: 0.009%
Covered Lines: 3516
Relevant Lines: 5603

💛 - Coveralls