search

m-lab / go

General purpose libraries / APIs for use in mlab code.
Apache License 2.0
5 stars 6 forks source link

Move testutil to new go repository #1

Closed gfr10598 closed 6 years ago

gfr10598 commented 6 years ago

Please also review the overall README file.

We may want to put more effort into the API and documentation. Not sure whether to do that first, or get something checked in and iterate.

This change is Reviewable

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 7be9b7a2f899cc83e28f0e1d6fdb6edd9936b7c6 on testutil into on master.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 505feca334f8ad3b647e21996a4ffc5ec6d73d45 on testutil into on master.

stephen-soltesz commented 6 years ago
:lgtm:

Reviewed 1 of 6 files at r1, 5 of 5 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.

.travis.yml, line 9 at r2 (raw file):

# credentials.
#Z
#  * decrypt service account credentials

Let's try the service-account-as-environment-variables approach this time.

i.e. https://github.com/m-lab/travis/blob/master/setup_service_accounts_for_travis.sh

README.md, line 6 at r2 (raw file):

| master | [![Travis Build Status](https://travis-ci.org/m-lab/go.svg?branch=master)](https://travis-ci.org/m-lab/go) | [![Coverage Status](https://coveralls.io/repos/m-lab/go/badge.svg?branch=master)](https://coveralls.io/github/m-lab/go?branch=master) |

[![Waffle.io](https://badge.waffle.io/m-lab/go.svg?title=Ready)](http://waffle.io/m-lab/go)

With the advent of scrumdo what will be our relationship with waffle.io going forward?

Comments from Reviewable

gfr10598 commented 6 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions.

.travis.yml, line 9 at r2 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…
Let's try the service-account-as-environment-variables approach this time. i.e. https://github.com/m-lab/travis/blob/master/setup_service_accounts_for_travis.sh

Ack - I'm doing that in the next PR.

README.md, line 6 at r2 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…
With the advent of scrumdo what will be our relationship with waffle.io going forward?

Ack. Don't know. Will fix when we do.

Comments from Reviewable

gfr10598 commented 6 years ago

Reviewed 1 of 6 files at r1, 5 of 5 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

gfr10598 commented 6 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions.

.travis.yml, line 9 at r2 (raw file):

Previously, gfr10598 (Gregory Russell) wrote…
Ack - I'm doing that in the next PR.

Done.

README.md, line 6 at r2 (raw file):

Previously, gfr10598 (Gregory Russell) wrote…
Ack. Don't know. Will fix when we do.

Done.

Comments from Reviewable

gfr10598 commented 6 years ago

OK

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

stephen-soltesz commented 6 years ago
:lgtm:

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

stephen-soltesz commented 6 years ago
:lgtm_strong:

Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

gfr10598 commented 6 years ago

LGTM

Comments from Reviewable