m-lab / go

General purpose libraries / APIs for use in mlab code.
Apache License 2.0
5 stars 6 forks source link

Allow for a 4 char suffix on the end of hostnames #156

Closed nkinkade closed 1 year ago

nkinkade commented 1 year ago

As we migrate cloud deployments to use a load balancer backed by managed instance groups, we can no longer count on machine names to be predetermined. MIG instances have a "-<4 char>" suffix, and are managed by the instance group, not M-Lab. In order to support this use case, the changes in this PR allow for a suffix to be part of the hostname without failing Parse(). Callers can use the suffix, if found, or not.


This change is Reviewable

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 1213


Files with Coverage Reduction New Missed Lines %
logx/logx.go 2 96.0%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 1208: -0.08%
Covered Lines: 2153
Relevant Lines: 2282

💛 - Coveralls