m-lab / k8s-support

Setup for the kubernetes systems to control and run all the MLab nodes around the world
Apache License 2.0
10 stars 10 forks source link

Removes conditional for packet-headers memory limit flags #862

Closed nkinkade closed 9 months ago

nkinkade commented 9 months ago

Previously, we restricted applying the flags -maxidleram and -maxheap to only VMs. This change applies those flags to all machine types, both VMs and physical. The expected outcome is that this shouldn't modify behavior of packet-headers on physical machines most all of the time, but may prevent packet-headers from eating up too much memory and invoking the oom-killer due to SYN floods or heavy traffic spikes. In either case packet-headers data is corrupted or non-existent, but with the flags it may not take the machine down or make it unresponsive.


This change is Reviewable