m-lab / locate

M-Lab Locate Service, a load balancer providing consistent “expected measurement quality” using access control
Apache License 2.0
9 stars 4 forks source link

Use correct machine hostname for Prometheus query #204

Closed cristinaleonr closed 5 days ago

cristinaleonr commented 5 days ago

This PR fixes the machine hostname used to query Prometheus for a single machine. Before, it was only passing in the "mlabN" part. Now, it's passing in the full name, which is needed to filter the metrics (example).

Note: I'm not sure what is happening with Coveralls. That file was not modified.


This change is Reviewable

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 1440

Details


Files with Coverage Reduction New Missed Lines %
cmd/heartbeat/main.go 4 83.21%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 1433: -0.2%
Covered Lines: 1835
Relevant Lines: 1897

💛 - Coveralls