search

m-lab / mlab-ns

M-Lab name server (load balancer for M-Lab servers)
Apache License 2.0
12 stars 10 forks source link

Skip 1g sites for single-server responses #226

Closed stephen-soltesz closed 4 years ago

stephen-soltesz commented 4 years ago

Fixes https://github.com/m-lab/mlab-ns/issues/225

For GeoResolver results requesting a single site, this change prevents ever returning 1g sites.

The rationale behind this is to prevent sending clients to tx-controller enabled 1g sites when rejected requests cannot fallback on a next server (which would be available when more than one server is returned). While it's still possible for 10g sites to reject requests the probability is much lower and the demand on such sites would be so high that most clients would be having a bad time under those conditions.

The consequence of this is client bias at 1g sites.

This change is Reviewable

stephen-soltesz commented 4 years ago

manually deployed sandbox. And, will deploy to staging after merge.